>>> Stage test was aborted due to an error, last 400 lines as follows: ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/Backend.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 85 | WARNING | Line exceeds 120 characters; contains 133 characters 91 | WARNING | Line exceeds 120 characters; contains 126 characters 123 | WARNING | Line exceeds 120 characters; contains 131 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Trust/Store.php ---------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES ---------------------------------------------------------------------- 120 | WARNING | Line exceeds 120 characters; contains 124 characters 154 | ERROR | Method name "_signCert" must not be prefixed with an | | underscore to indicate visibility 197 | ERROR | Method name "_createSSLOptions" must not be prefixed | | with an underscore to indicate visibility 235 | ERROR | Method name "_addSSLErrors" must not be prefixed | | with an underscore to indicate visibility 534 | ERROR | Method name "Store::proc_open" is not in camel caps | | format 614 | ERROR | Method name "Store::ocsp_validate" is not in camel | | caps format ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 60 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: ...mvc/app/library/OPNsense/System/Status/UnboundOverrideStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 58 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...sense/mvc/app/library/OPNsense/System/Status/LiveMediaStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 64 | WARNING | Line exceeds 120 characters; contains 129 characters 68 | WARNING | Line exceeds 120 characters; contains 149 characters ---------------------------------------------------------------------- FILE: ...mvc/app/library/OPNsense/System/Status/OpensshOverrideStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 48 | WARNING | Line exceeds 120 characters; contains 137 characters ---------------------------------------------------------------------- FILE: ...sense/mvc/app/library/OPNsense/System/Status/DiskSpaceStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 66 | WARNING | Line exceeds 120 characters; contains 123 characters 84 | WARNING | Line exceeds 120 characters; contains 123 characters 93 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/library/OPNsense/System/Status/CrashReporterStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 68 | WARNING | Line exceeds 120 characters; contains 125 characters 70 | WARNING | Line exceeds 120 characters; contains 162 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/library/OPNsense/System/Status/SystemBootingStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 50 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: ...pp/library/OPNsense/System/Status/ConfigdProxyOverrideStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 63 | WARNING | Line exceeds 120 characters; contains 132 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 116 | ERROR | Visibility must be declared on method "close" ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 316 | WARNING | Line exceeds 120 characters; contains 125 characters 492 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Base.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 268 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 299 | WARNING | Line exceeds 120 characters; contains 123 characters 512 | WARNING | Line exceeds 120 characters; contains 132 characters 514 | WARNING | Line exceeds 120 characters; contains 135 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 375 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | ERROR | The var keyword must not be used to declare a property 42 | ERROR | Visibility must be declared on property "$lastUsedAuth" ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/API.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 78 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 37 and the first side effect is on | | line 31. 151 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility 264 | WARNING | Line exceeds 120 characters; contains 159 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Local.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 125 | WARNING | Line exceeds 120 characters; contains 123 characters 152 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility ---------------------------------------------------------------------- FILE: ...re/src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 137 | WARNING | Line exceeds 120 characters; contains 123 characters 239 | WARNING | Line exceeds 120 characters; contains 131 characters 240 | WARNING | Line exceeds 120 characters; contains 140 characters 381 | WARNING | Line exceeds 120 characters; contains 126 characters ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 248 | WARNING | Line exceeds 120 characters; contains 121 characters 362 | WARNING | Line exceeds 120 characters; contains 139 characters 477 | WARNING | Line exceeds 120 characters; contains 134 characters ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 151 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 45 | WARNING | Visibility must be declared on all constants if your | | project supports PHP 7.1 or later ---------------------------------------------------------------------- FILE: .../core/src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 126 | WARNING | Line exceeds 120 characters; contains 143 characters ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/library/OPNsense/OpenVPN/BaseExporter.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 57 | ERROR | Method name "BaseExporter::export_pkcs12" is not in | | camel caps format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/library/OPNsense/OpenVPN/ExportFactory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 60 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: ...re/src/opnsense/mvc/app/library/OPNsense/OpenVPN/TheGreenBow.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 153 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- Time: 7.53 secs; Memory: 22MB PHPUnit 9.6.23 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.25 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ESSSSSSSSS..................................................... 63 / 249 ( 25%) ............................................................... 126 / 249 ( 50%) ................................E......F...F..FFFFFFF..EF...... 189 / 249 ( 75%) ............................................................ 249 / 249 (100%) Time: 00:00.089, Memory: 44.89 MB There were 3 errors: 1) tests\OPNsense\Base\AclTest::testCanBeCreated TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:478 /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:234 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclTest.php:48 2) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetSingleOk TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php:58 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:407 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:88 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:116 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:173 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php:214 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:69 3) tests\OPNsense\Base\FieldTypes\NetworkAliasFieldTest::testDefaultsExists TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php:58 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:407 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php:87 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php:214 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php:62 -- There were 10 failures: 1) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetNoneBlankDescSingleOk Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:208 2) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetMultiOk Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:289 3) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedOk Failed asserting that 3 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:349 4) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedNoneOk Failed asserting that 4 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:376 5) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedNoneWithMultipleOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:403 6) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectAllOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:439 7) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeOrderedOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:477 8) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeUnorderedOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:515 9) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeInvalidOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:554 10) tests\OPNsense\Base\FieldTypes\NetworkAliasFieldTest::testConfigItemsExists Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php:82 -- There were 9 skipped tests: 1) tests\OPNsense\Base\AclTest::test_root_hasPrivilege_not This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 2) tests\OPNsense\Base\AclTest::test_test1_hasPrivilege This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 3) tests\OPNsense\Base\AclTest::test_test2_hasPrivilege_via_group This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 4) tests\OPNsense\Base\AclTest::test_test3_hasPrivilege_not This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 5) tests\OPNsense\Base\AclTest::test_root_isPageAccessible_known This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 6) tests\OPNsense\Base\AclTest::test_root_isPageAccessible_unknown This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 7) tests\OPNsense\Base\AclTest::test_test2_isPageAccessible This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 8) tests\OPNsense\Base\AclTest::test_test4_isPageAccessible_via_group This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 9) tests\OPNsense\Base\AclTest::test_test1_isPageAccessible_unknown This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. ERRORS! Tests: 249, Assertions: 474, Errors: 3, Failures: 10, Skipped: 9. error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 59.87 real 52.29 user 18.00 sys