>>> Stage test was aborted due to an error, last 400 lines as follows: 288 | WARNING | Line exceeds 120 characters; contains 286 characters 297 | WARNING | Line exceeds 120 characters; contains 150 characters 300 | WARNING | Line exceeds 120 characters; contains 336 characters 463 | WARNING | Line exceeds 120 characters; contains 126 characters 484 | WARNING | Line exceeds 120 characters; contains 127 characters 553 | WARNING | Line exceeds 120 characters; contains 125 characters 596 | WARNING | Line exceeds 120 characters; contains 123 characters 806 | WARNING | Line exceeds 120 characters; contains 122 characters 863 | WARNING | Line exceeds 120 characters; contains 137 characters 991 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Unbound/Api/OverviewController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 53 | ERROR | Method name "OverviewController::RollingAction" is not | | in camel caps format ---------------------------------------------------------------------- FILE: ...ense/mvc/app/controllers/OPNsense/Monit/Api/StatusController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 64 | WARNING | Line exceeds 120 characters; contains 126 characters 65 | WARNING | Line exceeds 120 characters; contains 123 characters 67 | WARNING | Line exceeds 120 characters; contains 151 characters ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------------------------------------- 53 | ERROR | Method name "CrlController::phpseclib_autoload" is | | not in camel caps format 218 | WARNING | Line exceeds 120 characters; contains 123 characters 423 | ERROR | Visibility must be declared on method | | "getOcspInfoDataAction" ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 47 | ERROR | Method name "CaController::compare_issuer" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...nsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 111 | WARNING | Line exceeds 120 characters; contains 133 characters 112 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/library/OPNsense/Backup/GDrive.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 154 | ERROR | Empty ELSEIF statement detected ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 60 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: ...r/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 61 | ERROR | Visibility must be declared on method "__destruct" ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/File.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 41 | ERROR | Method name "File::file_put_contents" is not in camel | | caps format ---------------------------------------------------------------------- FILE: ...re/src/opnsense/mvc/app/library/OPNsense/Core/SanitizeFilter.php ---------------------------------------------------------------------- FOUND 9 ERRORS AFFECTING 9 LINES ---------------------------------------------------------------------- 44 | ERROR | Method name "SanitizeFilter::sanitize_item" is not in | | camel caps format 66 | ERROR | Method name "SanitizeFilter::filter_int" is not in | | camel caps format 71 | ERROR | Method name "SanitizeFilter::filter_string" is not in | | camel caps format 76 | ERROR | Method name "SanitizeFilter::filter_alnum" is not in | | camel caps format 81 | ERROR | Method name "SanitizeFilter::filter_hexval" is not in | | camel caps format 86 | ERROR | Method name "SanitizeFilter::filter_version" is not in | | camel caps format 91 | ERROR | Method name "SanitizeFilter::filter_query" is not in | | camel caps format 96 | ERROR | Method name "SanitizeFilter::filter_pkgname" is not in | | camel caps format 101 | ERROR | Method name "SanitizeFilter::filter_striptags" is not | | in camel caps format ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/Backend.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 85 | WARNING | Line exceeds 120 characters; contains 133 characters 91 | WARNING | Line exceeds 120 characters; contains 126 characters 123 | WARNING | Line exceeds 120 characters; contains 131 characters ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/library/OPNsense/OpenVPN/BaseExporter.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 57 | ERROR | Method name "BaseExporter::export_pkcs12" is not in | | camel caps format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/library/OPNsense/OpenVPN/ExportFactory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 60 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: ...re/src/opnsense/mvc/app/library/OPNsense/OpenVPN/TheGreenBow.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 153 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...re/src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 239 | WARNING | Line exceeds 120 characters; contains 131 characters 240 | WARNING | Line exceeds 120 characters; contains 140 characters 381 | WARNING | Line exceeds 120 characters; contains 126 characters ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 221 | WARNING | Line exceeds 120 characters; contains 121 characters 335 | WARNING | Line exceeds 120 characters; contains 139 characters 450 | WARNING | Line exceeds 120 characters; contains 134 characters ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 151 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 45 | WARNING | Visibility must be declared on all constants if your | | project supports PHP 7.1 or later ---------------------------------------------------------------------- FILE: ...mvc/app/library/OPNsense/System/Status/UnboundOverrideStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 58 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...sense/mvc/app/library/OPNsense/System/Status/LiveMediaStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 64 | WARNING | Line exceeds 120 characters; contains 129 characters 68 | WARNING | Line exceeds 120 characters; contains 149 characters ---------------------------------------------------------------------- FILE: ...mvc/app/library/OPNsense/System/Status/OpensshOverrideStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 48 | WARNING | Line exceeds 120 characters; contains 137 characters ---------------------------------------------------------------------- FILE: ...sense/mvc/app/library/OPNsense/System/Status/DiskSpaceStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 66 | WARNING | Line exceeds 120 characters; contains 123 characters 84 | WARNING | Line exceeds 120 characters; contains 123 characters 93 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/library/OPNsense/System/Status/CrashReporterStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 68 | WARNING | Line exceeds 120 characters; contains 125 characters 70 | WARNING | Line exceeds 120 characters; contains 162 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/library/OPNsense/System/Status/SystemBootingStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 50 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Trust/Store.php ---------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES ---------------------------------------------------------------------- 119 | WARNING | Line exceeds 120 characters; contains 124 characters 153 | ERROR | Method name "_signCert" must not be prefixed with an | | underscore to indicate visibility 196 | ERROR | Method name "_createSSLOptions" must not be prefixed | | with an underscore to indicate visibility 234 | ERROR | Method name "_addSSLErrors" must not be prefixed | | with an underscore to indicate visibility 533 | ERROR | Method name "Store::proc_open" is not in camel caps | | format 613 | ERROR | Method name "Store::ocsp_validate" is not in camel | | caps format ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 116 | ERROR | Visibility must be declared on method "close" ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 316 | WARNING | Line exceeds 120 characters; contains 125 characters 492 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Base.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 268 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 299 | WARNING | Line exceeds 120 characters; contains 123 characters 512 | WARNING | Line exceeds 120 characters; contains 132 characters 514 | WARNING | Line exceeds 120 characters; contains 135 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 374 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | ERROR | The var keyword must not be used to declare a property 42 | ERROR | Visibility must be declared on property "$lastUsedAuth" ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/API.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 78 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 37 and the first side effect is on | | line 31. 151 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility 264 | WARNING | Line exceeds 120 characters; contains 159 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Local.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 125 | WARNING | Line exceeds 120 characters; contains 123 characters 152 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility ---------------------------------------------------------------------- Time: 7.36 secs; Memory: 22MB PHPUnit 9.6.23 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.22 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ............................................................... 63 / 239 ( 26%) ....................................FF..FF..................... 126 / 239 ( 52%) ............................................................... 189 / 239 ( 79%) .................................................. 239 / 239 (100%) Time: 00:00.091, Memory: 44.89 MB There were 4 failures: 1) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testRequiredNotEmpty Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:71 2) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testValidValues Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:83 3) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testSelectSetWithoutUnknownValue Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:125 4) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testInverseOption Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:139 FAILURES! Tests: 239, Assertions: 484, Failures: 4. error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 63.04 real 61.78 user 19.12 sys