>>> Stage test was aborted due to an error, last 400 lines as follows: FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 78 | WARNING | Line exceeds 120 characters; contains 123 characters 81 | WARNING | Line exceeds 120 characters; contains 128 characters ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_3.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_3" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_4.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_4" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_2.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_2" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 33 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...c/opnsense/mvc/app/models/OPNsense/Dnsmasq/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 33 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...sr/core/src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 91 | WARNING | Line exceeds 120 characters; contains 123 characters 321 | WARNING | Line exceeds 120 characters; contains 144 characters ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_2.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_2" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 35 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_7.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_7" is not in PascalCase format 75 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_6.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_6" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...ense/mvc/app/models/OPNsense/TrafficShaper/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 35 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...sense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 120 | ERROR | Empty IF statement detected ---------------------------------------------------------------------- FILE: ...nse/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES ---------------------------------------------------------------------- 118 | WARNING | Line exceeds 120 characters; contains 123 characters 288 | WARNING | Line exceeds 120 characters; contains 286 characters 297 | WARNING | Line exceeds 120 characters; contains 150 characters 300 | WARNING | Line exceeds 120 characters; contains 336 characters 463 | WARNING | Line exceeds 120 characters; contains 126 characters 484 | WARNING | Line exceeds 120 characters; contains 127 characters 553 | WARNING | Line exceeds 120 characters; contains 125 characters 596 | WARNING | Line exceeds 120 characters; contains 123 characters 806 | WARNING | Line exceeds 120 characters; contains 122 characters 863 | WARNING | Line exceeds 120 characters; contains 137 characters 991 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Dnsmasq/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 79 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...p/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 136 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 486 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 94 | WARNING | Line exceeds 120 characters; contains 121 characters 194 | WARNING | Line exceeds 120 characters; contains 121 characters 272 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...nse/mvc/app/controllers/OPNsense/Firewall/OneToOneController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 50 | WARNING | Line exceeds 120 characters; contains 146 characters 56 | WARNING | Line exceeds 120 characters; contains 156 characters ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Unbound/Api/OverviewController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 53 | ERROR | Method name "OverviewController::RollingAction" is not | | in camel caps format ---------------------------------------------------------------------- FILE: .../app/controllers/OPNsense/CaptivePortal/Api/AccessController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 189 | WARNING | Line exceeds 120 characters; contains 123 characters 213 | WARNING | Line exceeds 120 characters; contains 126 characters 230 | WARNING | Line exceeds 120 characters; contains 123 characters 262 | WARNING | Line exceeds 120 characters; contains 126 characters ---------------------------------------------------------------------- FILE: ...app/controllers/OPNsense/CaptivePortal/Api/ServiceController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 102 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...ense/mvc/app/controllers/OPNsense/Monit/Api/StatusController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 64 | WARNING | Line exceeds 120 characters; contains 126 characters 65 | WARNING | Line exceeds 120 characters; contains 123 characters 67 | WARNING | Line exceeds 120 characters; contains 151 characters ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 96 | WARNING | Line exceeds 120 characters; contains 122 characters 220 | WARNING | Line exceeds 120 characters; contains 134 characters ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------------------------------------- 53 | ERROR | Method name "CrlController::phpseclib_autoload" is | | not in camel caps format 218 | WARNING | Line exceeds 120 characters; contains 123 characters 423 | ERROR | Visibility must be declared on method | | "getOcspInfoDataAction" ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 47 | ERROR | Method name "CaController::compare_issuer" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...nsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 111 | WARNING | Line exceeds 120 characters; contains 133 characters 112 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/controllers/OPNsense/Auth/Api/UserController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 43 | | and the first side effect is on line 31. ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/IPsec/Api/KeyPairsController.php ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 139 | ERROR | CASE statements must be defined using a colon 142 | ERROR | CASE statements must be defined using a colon 145 | ERROR | CASE statements must be defined using a colon ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/IPsec/Api/SessionsController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | ERROR | Method name "SessionsController::list_status" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 359 | ERROR | Method name "InterfaceController::CarpStatusAction" is | | not in camel caps format ---------------------------------------------------------------------- FILE: ...controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 153 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: .../app/controllers/OPNsense/Diagnostics/Api/CpuUsageController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | WARNING | Line exceeds 120 characters; contains 128 characters ---------------------------------------------------------------------- FILE: ...c/app/controllers/OPNsense/Diagnostics/Api/TrafficController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 45 | ERROR | Method name "TrafficController::InterfaceAction" is not | | in camel caps format 69 | ERROR | Method name "TrafficController::TopAction" is not in | | camel caps format ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 88 | WARNING | Line exceeds 120 characters; contains 143 characters 100 | WARNING | Line exceeds 120 characters; contains 138 characters ---------------------------------------------------------------------- FILE: ...mvc/app/controllers/OPNsense/DHCRelay/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 42 | WARNING | Line exceeds 120 characters; contains 121 characters 45 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/www/api.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 3 and | | the first side effect is on line 23. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/www/index.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 9 and | | the first side effect is on line 60. ---------------------------------------------------------------------- Time: 7.4 secs; Memory: 22MB PHPUnit 9.6.23 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.22 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ............................................................... 63 / 239 ( 26%) ....................................FF..FF..................... 126 / 239 ( 52%) ............................................................... 189 / 239 ( 79%) .................................................. 239 / 239 (100%) Time: 00:00.093, Memory: 44.89 MB There were 4 failures: 1) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testRequiredNotEmpty Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:71 2) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testValidValues Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:83 3) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testSelectSetWithoutUnknownValue Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:125 4) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testInverseOption Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:139 FAILURES! Tests: 239, Assertions: 484, Failures: 4. error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 64.52 real 62.36 user 19.60 sys