>>> Stage test was aborted due to an error, last 400 lines as follows: FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 34 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/Firmware.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES ---------------------------------------------------------------------- 62 | WARNING | Line exceeds 120 characters; contains 124 characters 74 | WARNING | Line exceeds 120 characters; contains 126 characters 130 | WARNING | Line exceeds 120 characters; contains 171 characters 131 | WARNING | Line exceeds 120 characters; contains 140 characters 134 | WARNING | Line exceeds 120 characters; contains 127 characters 136 | WARNING | Line exceeds 120 characters; contains 212 characters 139 | WARNING | Line exceeds 120 characters; contains 206 characters 144 | WARNING | Line exceeds 120 characters; contains 146 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 418 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: .../opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_1.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 37 | ERROR | Class name "M1_0_1" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 37 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../core/src/opnsense/mvc/app/models/OPNsense/DHCRelay/DHCRelay.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 57 | WARNING | Line exceeds 120 characters; contains 126 characters 92 | WARNING | Line exceeds 120 characters; contains 142 characters 94 | WARNING | Line exceeds 120 characters; contains 142 characters ---------------------------------------------------------------------- FILE: ...app/models/OPNsense/Interfaces/FieldTypes/VlanInterfaceField.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 48 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...c/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor/dhcpd.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 33 | ERROR | Class name "dhcpd" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...sr/core/src/opnsense/mvc/app/models/OPNsense/Interfaces/Vlan.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 75 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...r/core/src/opnsense/mvc/app/models/OPNsense/Interfaces/VxLan.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 47 | WARNING | Line exceeds 120 characters; contains 130 characters ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 100 | WARNING | Line exceeds 120 characters; contains 123 characters 197 | WARNING | Line exceeds 120 characters; contains 127 characters ---------------------------------------------------------------------- FILE: ...c/opnsense/mvc/app/models/OPNsense/Routing/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...r/core/src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php ---------------------------------------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 5 LINES ---------------------------------------------------------------------- 39 | ERROR | The var keyword must not be used to declare a | | property 39 | ERROR | Visibility must be declared on property | | "$configHandle" 40 | ERROR | The var keyword must not be used to declare a | | property 40 | ERROR | Visibility must be declared on property | | "$gatewaySeq" 41 | ERROR | The var keyword must not be used to declare a | | property 41 | ERROR | Visibility must be declared on property | | "$cached_gateways" 129 | WARNING | Line exceeds 120 characters; contains 121 characters 433 | ERROR | Empty IF statement detected ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/models/OPNsense/Wireguard/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 34 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_3.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_3" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_4.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_4" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_2.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_2" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 33 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/Wireguard/wg-service-control.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 39 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/auth/sync_user.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 54 | WARNING | Line exceeds 120 characters; contains 129 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/routes/gateway_watcher.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 35 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: .../src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Base.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 38 | ERROR | Visibility must be declared on property "$metadata" ---------------------------------------------------------------------- FILE: ...ore/src/opnsense/scripts/health/library/OPNsense/RRD/Factory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 40 | ERROR | Each class must be in a file by itself ---------------------------------------------------------------------- FILE: ...e/scripts/OPNsense/CaptivePortal/process_accounting_messages.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 87 | WARNING | Line exceeds 120 characters; contains 181 characters 94 | WARNING | Line exceeds 120 characters; contains 160 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/shell/setaddr.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 38 and the first side effect is on | | line 31. 237 | WARNING | Line exceeds 120 characters; contains 143 characters 253 | WARNING | Line exceeds 120 characters; contains 125 characters 325 | WARNING | Line exceeds 120 characters; contains 165 characters 340 | WARNING | Line exceeds 120 characters; contains 128 characters 397 | WARNING | Line exceeds 120 characters; contains 128 characters 507 | WARNING | Line exceeds 120 characters; contains 148 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/shell/banner.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 123 | WARNING | Line exceeds 120 characters; contains 196 characters 129 | WARNING | Line exceeds 120 characters; contains 146 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/interfaces/traffic_stats.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 32 | | and the first side effect is on line 29. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/firmware/register.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 53 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/firmware/product.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 38 | WARNING | Line exceeds 120 characters; contains 149 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/client_connect.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 43 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/user_pass_verify.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 42 and the first side effect is on | | line 30. 140 | WARNING | Line exceeds 120 characters; contains 159 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/ovpn_service_control.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 35 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/tls_verify.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 37 | | and the first side effect is on line 29. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/www/api.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 3 and | | the first side effect is on line 23. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/www/index.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 9 and | | the first side effect is on line 60. ---------------------------------------------------------------------- Time: 7.36 secs; Memory: 22MB PHPUnit 9.6.23 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.22 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ............................................................... 63 / 239 ( 26%) ....................................FF..FF..................... 126 / 239 ( 52%) ............................................................... 189 / 239 ( 79%) .................................................. 239 / 239 (100%) Time: 00:00.092, Memory: 44.89 MB There were 4 failures: 1) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testRequiredNotEmpty Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:71 2) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testValidValues Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:83 3) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testSelectSetWithoutUnknownValue Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:125 4) tests\OPNsense\Base\FieldTypes\CountryFieldTest::testInverseOption Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CountryFieldTest.php:139 FAILURES! Tests: 239, Assertions: 484, Failures: 4. error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 65.43 real 62.52 user 19.51 sys