>>> Stage test was aborted due to an error, last 400 lines as follows: FILE: ...sense/mvc/app/library/OPNsense/System/Status/LiveMediaStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 64 | WARNING | Line exceeds 120 characters; contains 129 characters 68 | WARNING | Line exceeds 120 characters; contains 149 characters ---------------------------------------------------------------------- FILE: ...mvc/app/library/OPNsense/System/Status/OpensshOverrideStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 48 | WARNING | Line exceeds 120 characters; contains 137 characters ---------------------------------------------------------------------- FILE: ...sense/mvc/app/library/OPNsense/System/Status/DiskSpaceStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 66 | WARNING | Line exceeds 120 characters; contains 123 characters 84 | WARNING | Line exceeds 120 characters; contains 123 characters 93 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/library/OPNsense/System/Status/CrashReporterStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 68 | WARNING | Line exceeds 120 characters; contains 125 characters 70 | WARNING | Line exceeds 120 characters; contains 162 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/library/OPNsense/System/Status/SystemBootingStatus.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 50 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 316 | WARNING | Line exceeds 120 characters; contains 125 characters 492 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Base.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 267 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 374 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | ERROR | The var keyword must not be used to declare a property 42 | ERROR | Visibility must be declared on property "$lastUsedAuth" ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/API.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 78 | ERROR | Method name "_authenticate" must not be prefixed with | | an underscore to indicate visibility ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 37 and the first side effect is on | | line 31. 151 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility 264 | WARNING | Line exceeds 120 characters; contains 159 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Auth/Local.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 125 | WARNING | Line exceeds 120 characters; contains 123 characters 152 | ERROR | Method name "_authenticate" must not be prefixed | | with an underscore to indicate visibility ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/library/OPNsense/Backup/GDrive.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 154 | ERROR | Empty ELSEIF statement detected ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 60 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 116 | ERROR | Visibility must be declared on method "close" ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Trust/Store.php ---------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES ---------------------------------------------------------------------- 119 | WARNING | Line exceeds 120 characters; contains 124 characters 153 | ERROR | Method name "_signCert" must not be prefixed with an | | underscore to indicate visibility 196 | ERROR | Method name "_createSSLOptions" must not be prefixed | | with an underscore to indicate visibility 234 | ERROR | Method name "_addSSLErrors" must not be prefixed | | with an underscore to indicate visibility 533 | ERROR | Method name "Store::proc_open" is not in camel caps | | format 609 | ERROR | Method name "Store::ocsp_validate" is not in camel | | caps format ---------------------------------------------------------------------- FILE: ...r/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 61 | ERROR | Visibility must be declared on method "__destruct" ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/File.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 41 | ERROR | Method name "File::file_put_contents" is not in camel | | caps format ---------------------------------------------------------------------- FILE: ...re/src/opnsense/mvc/app/library/OPNsense/Core/SanitizeFilter.php ---------------------------------------------------------------------- FOUND 9 ERRORS AFFECTING 9 LINES ---------------------------------------------------------------------- 44 | ERROR | Method name "SanitizeFilter::sanitize_item" is not in | | camel caps format 66 | ERROR | Method name "SanitizeFilter::filter_int" is not in | | camel caps format 71 | ERROR | Method name "SanitizeFilter::filter_string" is not in | | camel caps format 76 | ERROR | Method name "SanitizeFilter::filter_alnum" is not in | | camel caps format 81 | ERROR | Method name "SanitizeFilter::filter_hexval" is not in | | camel caps format 86 | ERROR | Method name "SanitizeFilter::filter_version" is not in | | camel caps format 91 | ERROR | Method name "SanitizeFilter::filter_query" is not in | | camel caps format 96 | ERROR | Method name "SanitizeFilter::filter_pkgname" is not in | | camel caps format 101 | ERROR | Method name "SanitizeFilter::filter_striptags" is not | | in camel caps format ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/Backend.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 85 | WARNING | Line exceeds 120 characters; contains 133 characters 91 | WARNING | Line exceeds 120 characters; contains 126 characters 123 | WARNING | Line exceeds 120 characters; contains 131 characters ---------------------------------------------------------------------- FILE: .../src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Base.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 38 | ERROR | Visibility must be declared on property "$metadata" ---------------------------------------------------------------------- FILE: ...ore/src/opnsense/scripts/health/library/OPNsense/RRD/Factory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 40 | ERROR | Each class must be in a file by itself ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/interfaces/traffic_stats.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 32 | | and the first side effect is on line 29. ---------------------------------------------------------------------- FILE: ...e/scripts/OPNsense/CaptivePortal/process_accounting_messages.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 86 | WARNING | Line exceeds 120 characters; contains 158 characters 93 | WARNING | Line exceeds 120 characters; contains 160 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/Wireguard/wg-service-control.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 39 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/auth/sync_user.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 54 | WARNING | Line exceeds 120 characters; contains 129 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/routes/gateway_watcher.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 35 and the first side effect is on | | line 30. 100 | WARNING | Line exceeds 120 characters; contains 165 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/firmware/register.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 53 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/firmware/product.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 38 | WARNING | Line exceeds 120 characters; contains 149 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/shell/setaddr.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 38 and the first side effect is on | | line 31. 237 | WARNING | Line exceeds 120 characters; contains 143 characters 253 | WARNING | Line exceeds 120 characters; contains 125 characters 325 | WARNING | Line exceeds 120 characters; contains 165 characters 340 | WARNING | Line exceeds 120 characters; contains 128 characters 397 | WARNING | Line exceeds 120 characters; contains 128 characters 507 | WARNING | Line exceeds 120 characters; contains 148 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/shell/banner.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 123 | WARNING | Line exceeds 120 characters; contains 196 characters 129 | WARNING | Line exceeds 120 characters; contains 146 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/client_connect.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 43 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/user_pass_verify.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 42 and the first side effect is on | | line 30. 140 | WARNING | Line exceeds 120 characters; contains 159 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/ovpn_service_control.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 35 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/tls_verify.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 37 | | and the first side effect is on line 29. ---------------------------------------------------------------------- Time: 7.08 secs; Memory: 22MB PHPUnit 9.6.22 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.19 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ............................................................... 63 / 239 ( 26%) ............................................................... 126 / 239 ( 52%) ............................................................... 189 / 239 ( 79%) .................................................. 239 / 239 (100%) Time: 00:00.091, Memory: 44.89 MB OK (239 tests, 485 assertions) error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 65.58 real 61.03 user 20.11 sys