>>> Stage test was aborted due to an error, last 400 lines as follows: ---------------------------------------------------------------------- 39 | ERROR | The var keyword must not be used to declare a | | property 39 | ERROR | Visibility must be declared on property | | "$configHandle" 40 | ERROR | The var keyword must not be used to declare a | | property 40 | ERROR | Visibility must be declared on property | | "$gatewaySeq" 41 | ERROR | The var keyword must not be used to declare a | | property 41 | ERROR | Visibility must be declared on property | | "$cached_gateways" 129 | WARNING | Line exceeds 120 characters; contains 121 characters 433 | ERROR | Empty IF statement detected ---------------------------------------------------------------------- FILE: ...p/models/OPNsense/Base/Constraints/ComparedToFieldConstraint.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 88 | ERROR | Method name | | "ComparedToFieldConstraint::is_constraint_fulfilled" is | | not in camel caps format ---------------------------------------------------------------------- FILE: ...c/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 552 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: ...c/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 186 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/models/OPNsense/Base/FieldTypes/IPPortField.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 154 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...re/src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 244 | WARNING | Line exceeds 120 characters; contains 144 characters 278 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------- 274 | WARNING | Line exceeds 120 characters; contains 123 characters 383 | WARNING | Line exceeds 120 characters; contains 121 characters 597 | WARNING | Line exceeds 120 characters; contains 123 characters 768 | WARNING | Line exceeds 120 characters; contains 122 characters 854 | ERROR | Method name "BaseModel::Default" is not in camel | | caps format ---------------------------------------------------------------------- FILE: ...ense/mvc/app/models/OPNsense/CaptivePortal/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 35 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...c/app/models/OPNsense/Firewall/FieldTypes/SourceNatRuleField.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 104 | ERROR | Each class must be in a file by itself ---------------------------------------------------------------------- FILE: .../mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 144 | ERROR | Each class must be in a file by itself ---------------------------------------------------------------------- FILE: ...e/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 83 | WARNING | Line exceeds 120 characters; contains 194 characters ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "MFP1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_3.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 39 | ERROR | Class name "MFP1_0_3" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_4.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 39 | ERROR | Class name "MFP1_0_4" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../opnsense/mvc/app/models/OPNsense/Firewall/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 39 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...sr/core/src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 154 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 69 | WARNING | Line exceeds 120 characters; contains 161 characters 74 | WARNING | Line exceeds 120 characters; contains 151 characters 78 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/models/OPNsense/Wireguard/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 34 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...p/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 136 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Unbound/Api/OverviewController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 53 | ERROR | Method name "OverviewController::RollingAction" is not | | in camel caps format ---------------------------------------------------------------------- FILE: ...sense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 120 | ERROR | Empty IF statement detected ---------------------------------------------------------------------- FILE: ...nse/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES ---------------------------------------------------------------------- 118 | WARNING | Line exceeds 120 characters; contains 123 characters 288 | WARNING | Line exceeds 120 characters; contains 286 characters 297 | WARNING | Line exceeds 120 characters; contains 150 characters 300 | WARNING | Line exceeds 120 characters; contains 336 characters 463 | WARNING | Line exceeds 120 characters; contains 126 characters 484 | WARNING | Line exceeds 120 characters; contains 127 characters 546 | WARNING | Line exceeds 120 characters; contains 125 characters 593 | WARNING | Line exceeds 120 characters; contains 123 characters 803 | WARNING | Line exceeds 120 characters; contains 122 characters 860 | WARNING | Line exceeds 120 characters; contains 137 characters 988 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 359 | ERROR | Method name "InterfaceController::CarpStatusAction" is | | not in camel caps format ---------------------------------------------------------------------- FILE: ...controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 153 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: .../app/controllers/OPNsense/Diagnostics/Api/CpuUsageController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | WARNING | Line exceeds 120 characters; contains 128 characters ---------------------------------------------------------------------- FILE: ...c/app/controllers/OPNsense/Diagnostics/Api/TrafficController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 45 | ERROR | Method name "TrafficController::InterfaceAction" is not | | in camel caps format 69 | ERROR | Method name "TrafficController::TopAction" is not in | | camel caps format ---------------------------------------------------------------------- FILE: .../app/controllers/OPNsense/CaptivePortal/Api/AccessController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 173 | WARNING | Line exceeds 120 characters; contains 123 characters 197 | WARNING | Line exceeds 120 characters; contains 126 characters 214 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: ...app/controllers/OPNsense/CaptivePortal/Api/ServiceController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 104 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...mvc/app/controllers/OPNsense/DHCRelay/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 42 | WARNING | Line exceeds 120 characters; contains 121 characters 45 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/IPsec/Api/KeyPairsController.php ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 139 | ERROR | CASE statements must be defined using a colon 142 | ERROR | CASE statements must be defined using a colon 145 | ERROR | CASE statements must be defined using a colon ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/IPsec/Api/SessionsController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | ERROR | Method name "SessionsController::list_status" is not in | | camel caps format ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 88 | WARNING | Line exceeds 120 characters; contains 143 characters 100 | WARNING | Line exceeds 120 characters; contains 138 characters ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 96 | WARNING | Line exceeds 120 characters; contains 122 characters 220 | WARNING | Line exceeds 120 characters; contains 134 characters ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/controllers/OPNsense/Auth/Api/UserController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 43 | | and the first side effect is on line 31. ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 486 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 40 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...nse/mvc/app/controllers/OPNsense/Firewall/OneToOneController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 50 | WARNING | Line exceeds 120 characters; contains 146 characters 56 | WARNING | Line exceeds 120 characters; contains 156 characters ---------------------------------------------------------------------- FILE: ...ense/mvc/app/controllers/OPNsense/Monit/Api/StatusController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 64 | WARNING | Line exceeds 120 characters; contains 126 characters 65 | WARNING | Line exceeds 120 characters; contains 123 characters 67 | WARNING | Line exceeds 120 characters; contains 151 characters ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------------------------------------- 53 | ERROR | Method name "CrlController::phpseclib_autoload" is | | not in camel caps format 218 | WARNING | Line exceeds 120 characters; contains 123 characters 423 | ERROR | Visibility must be declared on method | | "getOcspInfoDataAction" ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 47 | ERROR | Method name "CaController::compare_issuer" is not in | | camel caps format ---------------------------------------------------------------------- Time: 7.1 secs; Memory: 22MB PHPUnit 9.6.22 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.19 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ............................................................... 63 / 239 ( 26%) ............................................................... 126 / 239 ( 52%) ............................................................... 189 / 239 ( 79%) .................................................. 239 / 239 (100%) Time: 00:00.090, Memory: 44.89 MB OK (239 tests, 485 assertions) error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 64.52 real 60.86 user 20.22 sys