>>> Stage test was aborted due to an error, last 400 lines as follows: 96 | ERROR | Each class must be in a file by itself ---------------------------------------------------------------------- FILE: ...src/opnsense/mvc/app/models/OPNsense/Trust/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 35 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/models/OPNsense/Trust/Cert.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 46 | ERROR | Method name "Cert::compare_issuer" is not in camel caps | | format ---------------------------------------------------------------------- FILE: ...src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_6.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 33 | ERROR | Class name "M1_0_6" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_8.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 34 | ERROR | Class name "M1_0_8" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_7.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 33 | ERROR | Class name "M1_0_7" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 7 WARNINGS AFFECTING 8 LINES ---------------------------------------------------------------------- 35 | ERROR | Class name "M1_0_0" is not in PascalCase format 84 | WARNING | Line exceeds 120 characters; contains 144 characters 85 | WARNING | Line exceeds 120 characters; contains 138 characters 86 | WARNING | Line exceeds 120 characters; contains 132 characters 87 | WARNING | Line exceeds 120 characters; contains 143 characters 88 | WARNING | Line exceeds 120 characters; contains 143 characters 89 | WARNING | Line exceeds 120 characters; contains 146 characters 90 | WARNING | Line exceeds 120 characters; contains 132 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------- 170 | WARNING | Line exceeds 120 characters; contains 123 characters 189 | WARNING | Line exceeds 120 characters; contains 126 characters 191 | WARNING | Line exceeds 120 characters; contains 128 characters 208 | WARNING | Line exceeds 120 characters; contains 140 characters 210 | WARNING | Line exceeds 120 characters; contains 128 characters ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_2.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_2" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 35 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_7.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_7" is not in PascalCase format 75 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...e/src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_6.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_6" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...re/src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 179 | ERROR | Method name "MenuSystem::isc_v4_enabled" is not in | | camel caps format 270 | WARNING | Line exceeds 120 characters; contains 139 characters 304 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: ...c/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 592 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: ...c/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 186 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/models/OPNsense/Base/FieldTypes/IPPortField.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 122 | WARNING | Line exceeds 120 characters; contains 157 characters 125 | WARNING | Line exceeds 120 characters; contains 136 characters 131 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...p/models/OPNsense/Base/Constraints/ComparedToFieldConstraint.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 88 | ERROR | Method name | | "ComparedToFieldConstraint::is_constraint_fulfilled" is | | not in camel caps format ---------------------------------------------------------------------- FILE: ...usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 288 | WARNING | Line exceeds 120 characters; contains 123 characters 483 | WARNING | Line exceeds 120 characters; contains 121 characters 880 | WARNING | Line exceeds 120 characters; contains 122 characters 966 | ERROR | Method name "BaseModel::Default" is not in camel | | caps format ---------------------------------------------------------------------- FILE: .../opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_1.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 37 | ERROR | Class name "M1_0_1" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 37 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: .../core/src/opnsense/mvc/app/models/OPNsense/DHCRelay/DHCRelay.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 57 | WARNING | Line exceeds 120 characters; contains 126 characters 92 | WARNING | Line exceeds 120 characters; contains 142 characters 94 | WARNING | Line exceeds 120 characters; contains 142 characters ---------------------------------------------------------------------- FILE: ...ense/mvc/app/models/OPNsense/CaptivePortal/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 35 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...c/opnsense/mvc/app/models/OPNsense/Routing/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 36 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...r/core/src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php ---------------------------------------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 5 LINES ---------------------------------------------------------------------- 39 | ERROR | The var keyword must not be used to declare a | | property 39 | ERROR | Visibility must be declared on property | | "$configHandle" 40 | ERROR | The var keyword must not be used to declare a | | property 40 | ERROR | Visibility must be declared on property | | "$gatewaySeq" 41 | ERROR | The var keyword must not be used to declare a | | property 41 | ERROR | Visibility must be declared on property | | "$cached_gateways" 129 | WARNING | Line exceeds 120 characters; contains 121 characters 429 | ERROR | Empty IF statement detected ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/models/OPNsense/Wireguard/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 34 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: ...ense/mvc/app/models/OPNsense/TrafficShaper/Migrations/M1_0_0.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 35 | ERROR | Class name "M1_0_0" is not in PascalCase format ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/script/run_validations.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 59 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/script/run_migrations.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 63 | WARNING | Line exceeds 120 characters; contains 145 characters 76 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- Time: 7.44 secs; Memory: 22MB PHPUnit 9.6.23 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.23 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ESSSSSSSSS..................................................... 63 / 249 ( 25%) ............................................................... 126 / 249 ( 50%) ................................E......F...F..FFFFFFF..EF...... 189 / 249 ( 75%) ............................................................ 249 / 249 (100%) Time: 00:00.088, Memory: 44.89 MB There were 3 errors: 1) tests\OPNsense\Base\AclTest::testCanBeCreated TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:478 /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:234 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclTest.php:48 2) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetSingleOk TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php:58 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:419 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:76 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:106 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:165 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php:215 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:69 3) tests\OPNsense\Base\FieldTypes\NetworkAliasFieldTest::testDefaultsExists TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php:58 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:419 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php:87 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php:215 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php:62 -- There were 10 failures: 1) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetNoneBlankDescSingleOk Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:208 2) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetMultiOk Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:289 3) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedOk Failed asserting that 3 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:349 4) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedNoneOk Failed asserting that 4 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:376 5) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedNoneWithMultipleOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:403 6) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectAllOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:439 7) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeOrderedOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:477 8) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeUnorderedOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:515 9) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeInvalidOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:554 10) tests\OPNsense\Base\FieldTypes\NetworkAliasFieldTest::testConfigItemsExists Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php:82 -- There were 9 skipped tests: 1) tests\OPNsense\Base\AclTest::test_root_hasPrivilege_not This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 2) tests\OPNsense\Base\AclTest::test_test1_hasPrivilege This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 3) tests\OPNsense\Base\AclTest::test_test2_hasPrivilege_via_group This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 4) tests\OPNsense\Base\AclTest::test_test3_hasPrivilege_not This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 5) tests\OPNsense\Base\AclTest::test_root_isPageAccessible_known This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 6) tests\OPNsense\Base\AclTest::test_root_isPageAccessible_unknown This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 7) tests\OPNsense\Base\AclTest::test_test2_isPageAccessible This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 8) tests\OPNsense\Base\AclTest::test_test4_isPageAccessible_via_group This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 9) tests\OPNsense\Base\AclTest::test_test1_isPageAccessible_unknown This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. ERRORS! Tests: 249, Assertions: 474, Errors: 3, Failures: 10, Skipped: 9. error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 57.86 real 55.31 user 20.08 sys