>>> Stage test was aborted due to an error, last 400 lines as follows: ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 96 | WARNING | Line exceeds 120 characters; contains 122 characters 220 | WARNING | Line exceeds 120 characters; contains 134 characters ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/controllers/OPNsense/Auth/Api/UserController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 43 | | and the first side effect is on line 31. ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Dnsmasq/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 79 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...mvc/app/controllers/OPNsense/DHCRelay/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 42 | WARNING | Line exceeds 120 characters; contains 121 characters 45 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: ...app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 362 | ERROR | Method name "InterfaceController::CarpStatusAction" is | | not in camel caps format ---------------------------------------------------------------------- FILE: ...controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 153 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: .../app/controllers/OPNsense/Diagnostics/Api/CpuUsageController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | WARNING | Line exceeds 120 characters; contains 128 characters ---------------------------------------------------------------------- FILE: ...c/app/controllers/OPNsense/Diagnostics/Api/TrafficController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 45 | ERROR | Method name "TrafficController::InterfaceAction" is not | | in camel caps format 69 | ERROR | Method name "TrafficController::TopAction" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...sense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 120 | ERROR | Empty IF statement detected ---------------------------------------------------------------------- FILE: ...nse/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES ---------------------------------------------------------------------- 118 | WARNING | Line exceeds 120 characters; contains 123 characters 288 | WARNING | Line exceeds 120 characters; contains 286 characters 297 | WARNING | Line exceeds 120 characters; contains 150 characters 300 | WARNING | Line exceeds 120 characters; contains 336 characters 463 | WARNING | Line exceeds 120 characters; contains 126 characters 484 | WARNING | Line exceeds 120 characters; contains 127 characters 553 | WARNING | Line exceeds 120 characters; contains 125 characters 596 | WARNING | Line exceeds 120 characters; contains 123 characters 863 | WARNING | Line exceeds 120 characters; contains 137 characters 999 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: .../app/controllers/OPNsense/CaptivePortal/Api/AccessController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 112 | WARNING | Line exceeds 120 characters; contains 123 characters 136 | WARNING | Line exceeds 120 characters; contains 126 characters 153 | WARNING | Line exceeds 120 characters; contains 123 characters 185 | WARNING | Line exceeds 120 characters; contains 126 characters ---------------------------------------------------------------------- FILE: ...app/controllers/OPNsense/CaptivePortal/Api/ServiceController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 103 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...pnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------------------------------------- 53 | ERROR | Method name "CrlController::phpseclib_autoload" is | | not in camel caps format 218 | WARNING | Line exceeds 120 characters; contains 123 characters 423 | ERROR | Visibility must be declared on method | | "getOcspInfoDataAction" ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 47 | ERROR | Method name "CaController::compare_issuer" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...nsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 111 | WARNING | Line exceeds 120 characters; contains 133 characters 112 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 88 | WARNING | Line exceeds 120 characters; contains 143 characters 100 | WARNING | Line exceeds 120 characters; contains 138 characters ---------------------------------------------------------------------- FILE: ...ense/mvc/app/controllers/OPNsense/Monit/Api/StatusController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 64 | WARNING | Line exceeds 120 characters; contains 126 characters 65 | WARNING | Line exceeds 120 characters; contains 123 characters 67 | WARNING | Line exceeds 120 characters; contains 151 characters ---------------------------------------------------------------------- FILE: ...p/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 136 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/IPsec/Api/KeyPairsController.php ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 136 | ERROR | CASE statements must be defined using a colon 139 | ERROR | CASE statements must be defined using a colon 142 | ERROR | CASE statements must be defined using a colon ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/IPsec/Api/SessionsController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | ERROR | Method name "SessionsController::list_status" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 482 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 198 | WARNING | Line exceeds 120 characters; contains 121 characters 276 | WARNING | Line exceeds 120 characters; contains 122 characters ---------------------------------------------------------------------- FILE: ...nse/mvc/app/controllers/OPNsense/Firewall/OneToOneController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 50 | WARNING | Line exceeds 120 characters; contains 146 characters 56 | WARNING | Line exceeds 120 characters; contains 156 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/script/run_validations.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 59 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/script/run_migrations.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------- 63 | WARNING | Line exceeds 120 characters; contains 145 characters 76 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/www/api.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 3 and | | the first side effect is on line 23. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/www/index.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 9 and | | the first side effect is on line 60. ---------------------------------------------------------------------- Time: 7.47 secs; Memory: 22MB PHPUnit 9.6.23 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.23 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ESSSSSSSSS..................................................... 63 / 249 ( 25%) ............................................................... 126 / 249 ( 50%) ................................E......F...F..FFFFFFF..EF...... 189 / 249 ( 75%) ............................................................ 249 / 249 (100%) Time: 00:00.087, Memory: 44.89 MB There were 3 errors: 1) tests\OPNsense\Base\AclTest::testCanBeCreated TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:478 /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:234 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclTest.php:48 2) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetSingleOk TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php:58 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:419 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:76 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:106 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:165 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php:215 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:69 3) tests\OPNsense\Base\FieldTypes\NetworkAliasFieldTest::testDefaultsExists TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php:58 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:419 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php:87 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php:215 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php:62 -- There were 10 failures: 1) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetNoneBlankDescSingleOk Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:208 2) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetMultiOk Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:289 3) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedOk Failed asserting that 3 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:349 4) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedNoneOk Failed asserting that 4 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:376 5) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedNoneWithMultipleOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:403 6) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectAllOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:439 7) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeOrderedOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:477 8) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeUnorderedOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:515 9) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeInvalidOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:554 10) tests\OPNsense\Base\FieldTypes\NetworkAliasFieldTest::testConfigItemsExists Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php:82 -- There were 9 skipped tests: 1) tests\OPNsense\Base\AclTest::test_root_hasPrivilege_not This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 2) tests\OPNsense\Base\AclTest::test_test1_hasPrivilege This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 3) tests\OPNsense\Base\AclTest::test_test2_hasPrivilege_via_group This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 4) tests\OPNsense\Base\AclTest::test_test3_hasPrivilege_not This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 5) tests\OPNsense\Base\AclTest::test_root_isPageAccessible_known This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 6) tests\OPNsense\Base\AclTest::test_root_isPageAccessible_unknown This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 7) tests\OPNsense\Base\AclTest::test_test2_isPageAccessible This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 8) tests\OPNsense\Base\AclTest::test_test4_isPageAccessible_via_group This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 9) tests\OPNsense\Base\AclTest::test_test1_isPageAccessible_unknown This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. ERRORS! Tests: 249, Assertions: 474, Errors: 3, Failures: 10, Skipped: 9. error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 57.35 real 54.53 user 20.13 sys