>>> Stage test was aborted due to an error, last 400 lines as follows: FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 100 | ERROR | Each class must be in a file by itself ---------------------------------------------------------------------- FILE: ...dels/OPNsense/Base/Constraints/ComparedToFieldConstraintTest.php ---------------------------------------------------------------------- FOUND 14 ERRORS AFFECTING 14 LINES ---------------------------------------------------------------------- 41 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_number_ranges_correctly_with_lt_and_no_error" | | is not in camel caps format 51 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_number_ranges_correctly_with_lt_and_error" | | is not in camel caps format 61 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_number_ranges_correctly_with_gt_and_no_error" | | is not in camel caps format 71 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_number_ranges_correctly_with_gt_and_error" | | is not in camel caps format 82 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_zero_number_ranges_correctly_with_lt_and_error" | | is not in camel caps format 91 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_zero_number_ranges_correctly_with_gt_and_error" | | is not in camel caps format 100 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_zero_number_ranges_correctly_with_lt_and_no_error" | | is not in camel caps format 109 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_zero_number_ranges_correctly_with_gt_and_no_error" | | is not in camel caps format 120 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_node_empty_values_correctly_with_gt_and_no_error" | | is not in camel caps format 129 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_other_node_empty_values_correctly_with_gt_and_no_error" | | is not in camel caps format 140 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_constraint_if_node_is_null_and_no_error" | | is not in camel caps format 149 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_constraint_if_other_is_null_and_no_error" | | is not in camel caps format 158 | ERROR | Method name | | "ComparedToFieldConstraintTest::test_if_it_validates_constraint_if_both_are_null_and_no_error" | | is not in camel caps format 175 | ERROR | Method name | | "ComparedToFieldConstraintTest::make_validator" is not | | in camel caps format ---------------------------------------------------------------------- FILE: ...rc/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModelTest.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 35 | | and the first side effect is on line 33. ---------------------------------------------------------------------- FILE: .../core/src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclTest.php ---------------------------------------------------------------------- FOUND 9 ERRORS AFFECTING 9 LINES ---------------------------------------------------------------------- 55 | ERROR | Method name "AclTest::test_root_hasPrivilege_not" is | | not in camel caps format 63 | ERROR | Method name "AclTest::test_test1_hasPrivilege" is not | | in camel caps format 71 | ERROR | Method name | | "AclTest::test_test2_hasPrivilege_via_group" is not in | | camel caps format 79 | ERROR | Method name "AclTest::test_test3_hasPrivilege_not" is | | not in camel caps format 87 | ERROR | Method name | | "AclTest::test_root_isPageAccessible_known" is not in | | camel caps format 95 | ERROR | Method name | | "AclTest::test_root_isPageAccessible_unknown" is not | | in camel caps format 103 | ERROR | Method name "AclTest::test_test2_isPageAccessible" is | | not in camel caps format 111 | ERROR | Method name | | "AclTest::test_test4_isPageAccessible_via_group" is | | not in camel caps format 119 | ERROR | Method name | | "AclTest::test_test1_isPageAccessible_unknown" is not | | in camel caps format ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/client_connect.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 43 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/user_pass_verify.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 42 and the first side effect is on | | line 30. 141 | WARNING | Line exceeds 120 characters; contains 159 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/ovpn_service_control.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 35 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/tls_verify.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 37 | | and the first side effect is on line 29. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/firmware/register.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 53 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/firmware/product.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 38 | WARNING | Line exceeds 120 characters; contains 149 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/auth/sync_user.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 54 | WARNING | Line exceeds 120 characters; contains 129 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/routes/gateway_watcher.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 35 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/shell/setaddr.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 38 and the first side effect is on | | line 31. 237 | WARNING | Line exceeds 120 characters; contains 143 characters 253 | WARNING | Line exceeds 120 characters; contains 125 characters 330 | WARNING | Line exceeds 120 characters; contains 165 characters 344 | WARNING | Line exceeds 120 characters; contains 128 characters 401 | WARNING | Line exceeds 120 characters; contains 128 characters 520 | WARNING | Line exceeds 120 characters; contains 148 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/shell/banner.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 123 | WARNING | Line exceeds 120 characters; contains 196 characters 129 | WARNING | Line exceeds 120 characters; contains 146 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/interfaces/traffic_stats.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 32 | | and the first side effect is on line 29. ---------------------------------------------------------------------- FILE: ...e/scripts/OPNsense/CaptivePortal/process_accounting_messages.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 87 | WARNING | Line exceeds 120 characters; contains 181 characters 94 | WARNING | Line exceeds 120 characters; contains 160 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/Wireguard/wg-service-control.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 39 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: .../src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Base.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 38 | ERROR | Visibility must be declared on property "$metadata" ---------------------------------------------------------------------- FILE: ...ore/src/opnsense/scripts/health/library/OPNsense/RRD/Factory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 40 | ERROR | Each class must be in a file by itself ---------------------------------------------------------------------- Time: 7.52 secs; Memory: 22MB PHPUnit 9.6.23 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.23 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ESSSSSSSSS..................................................... 63 / 249 ( 25%) ............................................................... 126 / 249 ( 50%) ................................E......F...F..FFFFFFF..EF...... 189 / 249 ( 75%) ............................................................ 249 / 249 (100%) Time: 00:00.087, Memory: 44.89 MB There were 3 errors: 1) tests\OPNsense\Base\AclTest::testCanBeCreated TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:478 /usr/core/src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:234 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclTest.php:48 2) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetSingleOk TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php:58 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:419 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:76 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:106 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php:165 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php:215 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:69 3) tests\OPNsense\Base\FieldTypes\NetworkAliasFieldTest::testDefaultsExists TypeError: flock(): Argument #1 ($stream) must be of type resource, false given /usr/core/src/opnsense/mvc/app/library/OPNsense/Core/FileObject.php:58 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:419 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php:87 /usr/core/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php:215 /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php:62 -- There were 10 failures: 1) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetNoneBlankDescSingleOk Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:208 2) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSetMultiOk Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:289 3) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedOk Failed asserting that 3 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:349 4) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedNoneOk Failed asserting that 4 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:376 5) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedNoneWithMultipleOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:403 6) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectAllOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:439 7) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeOrderedOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:477 8) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeUnorderedOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:515 9) tests\OPNsense\Base\FieldTypes\ModelRelationFieldTest::testSortedSelectSomeInvalidOk Failed asserting that 1 matches expected false. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php:554 10) tests\OPNsense\Base\FieldTypes\NetworkAliasFieldTest::testConfigItemsExists Failed asserting that an array is empty. /usr/core/src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php:82 -- There were 9 skipped tests: 1) tests\OPNsense\Base\AclTest::test_root_hasPrivilege_not This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 2) tests\OPNsense\Base\AclTest::test_test1_hasPrivilege This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 3) tests\OPNsense\Base\AclTest::test_test2_hasPrivilege_via_group This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 4) tests\OPNsense\Base\AclTest::test_test3_hasPrivilege_not This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 5) tests\OPNsense\Base\AclTest::test_root_isPageAccessible_known This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 6) tests\OPNsense\Base\AclTest::test_root_isPageAccessible_unknown This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 7) tests\OPNsense\Base\AclTest::test_test2_isPageAccessible This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 8) tests\OPNsense\Base\AclTest::test_test4_isPageAccessible_via_group This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. 9) tests\OPNsense\Base\AclTest::test_test1_isPageAccessible_unknown This test depends on "tests\OPNsense\Base\AclTest::testCanBeCreated" to pass. ERRORS! Tests: 249, Assertions: 474, Errors: 3, Failures: 10, Skipped: 9. error: unable to create file src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml: File exists Updated 0 paths from the index *** Error code 255 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 56.91 real 55.59 user 20.75 sys