>>> Stage test was aborted due to an error, last 400 lines as follows: FILE: ...opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 47 | ERROR | Method name "CaController::compare_issuer" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...ense/mvc/app/controllers/OPNsense/Monit/Api/StatusController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 64 | WARNING | Line exceeds 120 characters; contains 126 characters 65 | WARNING | Line exceeds 120 characters; contains 123 characters 67 | WARNING | Line exceeds 120 characters; contains 151 characters ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Unbound/Api/OverviewController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 53 | ERROR | Method name "OverviewController::RollingAction" is not | | in camel caps format ---------------------------------------------------------------------- FILE: .../app/controllers/OPNsense/CaptivePortal/Api/AccessController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 173 | WARNING | Line exceeds 120 characters; contains 123 characters 197 | WARNING | Line exceeds 120 characters; contains 126 characters 214 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: ...app/controllers/OPNsense/CaptivePortal/Api/ServiceController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 103 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/IPsec/Api/KeyPairsController.php ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 139 | ERROR | CASE statements must be defined using a colon 142 | ERROR | CASE statements must be defined using a colon 145 | ERROR | CASE statements must be defined using a colon ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/IPsec/Api/SessionsController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | ERROR | Method name "SessionsController::list_status" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 96 | WARNING | Line exceeds 120 characters; contains 122 characters 220 | WARNING | Line exceeds 120 characters; contains 134 characters ---------------------------------------------------------------------- FILE: ...app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 359 | ERROR | Method name "InterfaceController::CarpStatusAction" is | | not in camel caps format ---------------------------------------------------------------------- FILE: ...controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 153 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: .../app/controllers/OPNsense/Diagnostics/Api/CpuUsageController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 42 | WARNING | Line exceeds 120 characters; contains 128 characters ---------------------------------------------------------------------- FILE: ...c/app/controllers/OPNsense/Diagnostics/Api/TrafficController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 45 | ERROR | Method name "TrafficController::InterfaceAction" is not | | in camel caps format 69 | ERROR | Method name "TrafficController::TopAction" is not in | | camel caps format ---------------------------------------------------------------------- FILE: ...se/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 471 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: ...e/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 40 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: ...p/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 136 | WARNING | Line exceeds 120 characters; contains 125 characters ---------------------------------------------------------------------- FILE: .../mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 88 | WARNING | Line exceeds 120 characters; contains 143 characters 100 | WARNING | Line exceeds 120 characters; contains 138 characters ---------------------------------------------------------------------- FILE: ...mvc/app/controllers/OPNsense/DHCRelay/Api/SettingsController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 42 | WARNING | Line exceeds 120 characters; contains 121 characters 45 | WARNING | Line exceeds 120 characters; contains 123 characters ---------------------------------------------------------------------- FILE: ...sense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 98 | ERROR | Empty IF statement detected ---------------------------------------------------------------------- FILE: ...nse/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES ---------------------------------------------------------------------- 118 | WARNING | Line exceeds 120 characters; contains 123 characters 288 | WARNING | Line exceeds 120 characters; contains 286 characters 297 | WARNING | Line exceeds 120 characters; contains 150 characters 300 | WARNING | Line exceeds 120 characters; contains 336 characters 463 | WARNING | Line exceeds 120 characters; contains 126 characters 484 | WARNING | Line exceeds 120 characters; contains 127 characters 546 | WARNING | Line exceeds 120 characters; contains 125 characters 593 | WARNING | Line exceeds 120 characters; contains 123 characters 803 | WARNING | Line exceeds 120 characters; contains 122 characters 860 | WARNING | Line exceeds 120 characters; contains 137 characters 988 | WARNING | Line exceeds 120 characters; contains 121 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/script/run_validations.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 59 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/mvc/script/run_migrations.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 76 | ERROR | Empty CATCH statement detected ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/www/api.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 3 and | | the first side effect is on line 23. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/www/index.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 9 and | | the first side effect is on line 60. ---------------------------------------------------------------------- FILE: ...e/scripts/OPNsense/CaptivePortal/process_accounting_messages.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 86 | WARNING | Line exceeds 120 characters; contains 158 characters 93 | WARNING | Line exceeds 120 characters; contains 160 characters ---------------------------------------------------------------------- FILE: .../src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Base.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 38 | ERROR | Visibility must be declared on property "$metadata" ---------------------------------------------------------------------- FILE: ...ore/src/opnsense/scripts/health/library/OPNsense/RRD/Factory.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 40 | ERROR | Each class must be in a file by itself ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/Wireguard/wg-service-control.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 39 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/shell/setaddr.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 39 and the first side effect is on | | line 31. 238 | WARNING | Line exceeds 120 characters; contains 143 characters 254 | WARNING | Line exceeds 120 characters; contains 125 characters 326 | WARNING | Line exceeds 120 characters; contains 165 characters 341 | WARNING | Line exceeds 120 characters; contains 128 characters 398 | WARNING | Line exceeds 120 characters; contains 128 characters 508 | WARNING | Line exceeds 120 characters; contains 148 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/shell/banner.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 123 | WARNING | Line exceeds 120 characters; contains 196 characters 129 | WARNING | Line exceeds 120 characters; contains 146 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/routes/gateway_watcher.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 35 and the first side effect is on | | line 30. 100 | WARNING | Line exceeds 120 characters; contains 165 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/interfaces/traffic_stats.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 32 | | and the first side effect is on line 29. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/firmware/register.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 53 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/firmware/product.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 38 | WARNING | Line exceeds 120 characters; contains 149 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/client_connect.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 43 | WARNING | Line exceeds 120 characters; contains 124 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/user_pass_verify.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, | | functions, constants, etc.) and cause no other side | | effects, or it should execute logic with side | | effects, but should not do both. The first symbol is | | defined on line 42 and the first side effect is on | | line 30. 131 | WARNING | Line exceeds 120 characters; contains 159 characters ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/ovpn_service_control.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 35 | | and the first side effect is on line 30. ---------------------------------------------------------------------- FILE: /usr/core/src/opnsense/scripts/openvpn/tls_verify.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 1 | WARNING | A file should declare new symbols (classes, functions, | | constants, etc.) and cause no other side effects, or | | it should execute logic with side effects, but should | | not do both. The first symbol is defined on line 37 | | and the first side effect is on line 29. ---------------------------------------------------------------------- Time: 6.74 secs; Memory: 22MB PHPUnit 9.6.22 by Sebastian Bergmann and contributors. Runtime: PHP 8.2.27 Configuration: /usr/core/src/opnsense/mvc/tests/phpunit.xml ............................................................... 63 / 219 ( 28%) ............................................................... 126 / 219 ( 57%) ............................................................... 189 / 219 ( 86%) .............................. 219 / 219 (100%) Time: 00:10.741, Memory: 50.90 MB OK (219 tests, 456 assertions) error: pathspec '/usr/core/src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml' did not match any file(s) known to git *** Error code 1 Stop. make[2]: stopped in /usr/core *** Error code 1 Stop. make[1]: stopped in /usr/tools 72.98 real 57.31 user 24.42 sys